diff --git a/src/backend/rumBkdFile.erl b/src/backend/rumBkdFile.erl index a2ec615..7b0bfaa 100644 --- a/src/backend/rumBkdFile.erl +++ b/src/backend/rumBkdFile.erl @@ -302,7 +302,6 @@ validate_loglevel(Level) -> checkOpts([], IsFile) -> ?IIF(IsFile, true, {error, no_file_name}); checkOpts([{file, _File} | Tail], _IsFile) -> - %% is there any reasonable validation we can do here? checkOpts(Tail, true); checkOpts([{level, Level} | Tail], IsFile) -> ?IIF(validate_loglevel(Level), checkOpts(Tail, IsFile), ({error, {invalid_log_level, Level}})); @@ -315,17 +314,14 @@ checkOpts([{rotator, Rotator} | Tail], IsFile) when is_atom(Rotator) -> checkOpts([{high_water_mark, HighWaterMark} | Tail], IsFile) when is_integer(HighWaterMark), HighWaterMark >= 0 -> checkOpts(Tail, IsFile); checkOpts([{date, _Date} | Tail], IsFile) -> - %% IMY-todo 使用前需要转换一下 rumUtil:parseRotateSpec(_Date) checkOpts(Tail, IsFile); checkOpts([{sync_interval, SyncInt} | Tail], IsFile) when is_integer(SyncInt), SyncInt >= 0 -> checkOpts(Tail, IsFile); checkOpts([{sync_size, SyncSize} | Tail], IsFile) when is_integer(SyncSize), SyncSize >= 0 -> checkOpts(Tail, IsFile); checkOpts([{check_interval, CheckInt} | Tail], IsFile) when is_integer(CheckInt), CheckInt >= 0; CheckInt == always -> - %% IMY-todo 使用前转换一下 always ->{check_interval, 0}; checkOpts(Tail, IsFile); checkOpts([{sync_on, _Level} | Tail], IsFile) -> - %% IMY-todo 使用前转换一下 validate_loglevel(Level) checkOpts(Tail, IsFile); checkOpts([{formatter, Fmt} | Tail], IsFile) when is_atom(Fmt) -> checkOpts(Tail, IsFile);