Procházet zdrojové kódy

Fix binary leak when encoding large strings

This bug was due to an interaction between two optimizations. If we
attempt to flush the buffer before any bytes are used we refused.
However, in enc_ensure we were not checking whether the buffer was
actually flushed so we would allocate a new buffer for the request.

The easiest way to encounter this issue was by encoding a raw binary
longer than 2041 bytes (i.e., `jiffy:encode(<<"stuff...">>).`).
pull/198/head
Paul J. Davis před 5 roky
rodič
revize
0ba322e421
1 změnil soubory, kde provedl 4 přidání a 0 odebrání
  1. +4
    -0
      c_src/encoder.c

+ 4
- 0
c_src/encoder.c Zobrazit soubor

@ -166,6 +166,10 @@ enc_ensure(Encoder* e, size_t req)
if(!enc_flush(e)) {
return 0;
}
if(e->have_buffer) {
return 1;
}
}
for(new_size = BIN_INC_SIZE; new_size < req; new_size <<= 1);

Načítá se…
Zrušit
Uložit