瀏覽代碼

Fix binary leak when encoding large strings

This bug was due to an interaction between two optimizations. If we
attempt to flush the buffer before any bytes are used we refused.
However, in enc_ensure we were not checking whether the buffer was
actually flushed so we would allocate a new buffer for the request.

The easiest way to encounter this issue was by encoding a raw binary
longer than 2041 bytes (i.e., `jiffy:encode(<<"stuff...">>).`).
pull/198/head
Paul J. Davis 5 年之前
父節點
當前提交
0ba322e421
共有 1 個文件被更改,包括 4 次插入0 次删除
  1. +4
    -0
      c_src/encoder.c

+ 4
- 0
c_src/encoder.c 查看文件

@ -166,6 +166,10 @@ enc_ensure(Encoder* e, size_t req)
if(!enc_flush(e)) {
return 0;
}
if(e->have_buffer) {
return 1;
}
}
for(new_size = BIN_INC_SIZE; new_size < req; new_size <<= 1);

Loading…
取消
儲存