From c842cc1618e46e16307478a74833d18b3430826e Mon Sep 17 00:00:00 2001 From: Nobuhiro Iwamatsu Date: Tue, 2 Jul 2013 13:05:54 +0900 Subject: [PATCH 1/3] Fix typo in utils.h Signed-off-by: Nobuhiro Iwamatsu --- c_src/double-conversion/utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c_src/double-conversion/utils.h b/c_src/double-conversion/utils.h index a19f85a..7fb7f04 100644 --- a/c_src/double-conversion/utils.h +++ b/c_src/double-conversion/utils.h @@ -300,7 +300,7 @@ class StringBuilder { // #if defined(__GCC__) -#define UNUSED __atribute__((unused)) +#define UNUSED __attribute__((unused)) #else #define UNUSED #endif From f5f5e53f50a6879c581856249e34cef74a5e0368 Mon Sep 17 00:00:00 2001 From: Nobuhiro Iwamatsu Date: Tue, 2 Jul 2013 12:45:55 +0900 Subject: [PATCH 2/3] __GNUC__ is a better choice than __GCC__ Signed-off-by: Nobuhiro Iwamatsu --- c_src/double-conversion/utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c_src/double-conversion/utils.h b/c_src/double-conversion/utils.h index 7fb7f04..9ebb9ee 100644 --- a/c_src/double-conversion/utils.h +++ b/c_src/double-conversion/utils.h @@ -299,7 +299,7 @@ class StringBuilder { // PJD: 4-24-2013 // -#if defined(__GCC__) +#if defined(__GNUC__) #define UNUSED __attribute__((unused)) #else #define UNUSED From 80f2f8347c798577775bcbf162294d2bdf30ddaf Mon Sep 17 00:00:00 2001 From: Nobuhiro Iwamatsu Date: Tue, 2 Jul 2013 13:38:49 +0900 Subject: [PATCH 3/3] Add check for below array bounds Signed-off-by: Nobuhiro Iwamatsu --- c_src/double-conversion/fast-dtoa.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/c_src/double-conversion/fast-dtoa.cc b/c_src/double-conversion/fast-dtoa.cc index 1a0f823..b2f7b8d 100644 --- a/c_src/double-conversion/fast-dtoa.cc +++ b/c_src/double-conversion/fast-dtoa.cc @@ -253,6 +253,8 @@ static void BiggestPowerTen(uint32_t number, // number < (2^number_bits - 2) yet. while (number < kSmallPowersOfTen[exponent_plus_one_guess]) { exponent_plus_one_guess--; + if (exponent_plus_one_guess <= 0) + break; } *power = kSmallPowersOfTen[exponent_plus_one_guess]; *exponent_plus_one = exponent_plus_one_guess;