From fee31c6afc8807428857fdb365eb0952e028f519 Mon Sep 17 00:00:00 2001 From: Marcin Chalczynski Date: Fri, 24 Jul 2015 10:38:06 +0200 Subject: [PATCH] bignum.cc: fix -Werror=strict-overflow issue Fixes compilation error with GCC 5.x: c_src/double-conversion/bignum.cc:102:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] void Bignum::AssignDecimalString(Vector value) { ^ cc1plus: all warnings being treated as errors --- c_src/double-conversion/bignum.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c_src/double-conversion/bignum.cc b/c_src/double-conversion/bignum.cc index 89c0ab2..7c88ff7 100644 --- a/c_src/double-conversion/bignum.cc +++ b/c_src/double-conversion/bignum.cc @@ -104,7 +104,7 @@ void Bignum::AssignDecimalString(Vector value) { const int kMaxUint64DecimalDigits = 19; Zero(); int length = value.length(); - int pos = 0; + unsigned int pos = 0; // Let's just say that each digit needs 4 bits. while (length >= kMaxUint64DecimalDigits) { uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits);