Fix dialyzer errors

src/error_logger_lager_h.erl

@@ -360,13 +360,11 @@ log_event(Event, #state{sink=Sink} = State) ->
         no_log ->
             Shaper = State#state.shaper,
             {ok, State#state{
-                shaper = Shaper#lager_shaper{
-                    mps = Shaper#lager_shaper.mps - 1
-                }
-            }};
-        Invalid ->
-            ?LOGFMT(Sink, error, self(), "Unexpeted log result: ~p", [Invalid]),
-            {ok, State}
+                   shaper = Shaper#lager_shaper{
+                              mps = Shaper#lager_shaper.mps - 1
+                             }
+                  }
+            }
     end.
 
 format_crash_report(Report, Neighbours) ->

src/lager.erl

@@ -691,7 +691,7 @@ rotate_handler(Handler, Sink) ->
 
 %% @private
 trace_func(#trace_func_state_v1{pid=Pid, level=Level, format_string=Fmt}=FuncState, Event, ProcState) ->
-    lager:log(Level, Pid, Fmt, [Event, ProcState]),
+    _ = lager:log(Level, Pid, Fmt, [Event, ProcState]),
     check_timeout(decrement_count(FuncState)).
 
 %% @private

src/lager_app.erl

@@ -167,7 +167,7 @@ start_error_logger_handler(true, HWM, WhiteList) ->
             %%
             %% Longer term we should be installing a logger handler instead, but this will bridge the gap
             %% for now.
-            error_logger:start(),
+            _ = error_logger:start(),
             _ = logger:add_handler(error_logger,error_logger,#{level=>info,filter_default=>log}),
             ok = maybe_remove_logger_handler();
         _ ->

src/lager_file_backend.erl

@@ -195,17 +195,17 @@ handle_info({rotate, File}, #state{name=File,count=Count,date=Date,rotator=Rotat
     schedule_rotation(File, Date),
     {ok, State1};
 handle_info({shaper_expired, Name}, #state{shaper=Shaper, name=Name, formatter=Formatter, formatter_config=FormatConfig} = State) ->
-    case Shaper#lager_shaper.dropped of
-        0 ->
-            ok;
-        Dropped ->
-            Report = io_lib:format(
-                       "lager_file_backend dropped ~p messages in the last second that exceeded the limit of ~p messages/sec",
-                       [Dropped, Shaper#lager_shaper.hwm]),
-            ReportMsg = lager_msg:new(Report, warning, [], []),
-            write(State, lager_msg:timestamp(ReportMsg),
-                  lager_msg:severity_as_int(ReportMsg), Formatter:format(ReportMsg, FormatConfig))
-    end,
+    _ = case Shaper#lager_shaper.dropped of
+            0 ->
+                ok;
+            Dropped ->
+                Report = io_lib:format(
+                           "lager_file_backend dropped ~p messages in the last second that exceeded the limit of ~p messages/sec",
+                           [Dropped, Shaper#lager_shaper.hwm]),
+                ReportMsg = lager_msg:new(Report, warning, [], []),
+                write(State, lager_msg:timestamp(ReportMsg),
+                      lager_msg:severity_as_int(ReportMsg), Formatter:format(ReportMsg, FormatConfig))
+        end,
     {ok, State#state{shaper=Shaper#lager_shaper{dropped=0, mps=0, lasttime=os:timestamp()}}};
 handle_info(_Info, State) ->
     {ok, State}.

src/lager_handler_watcher.erl

@@ -75,7 +75,7 @@ handle_info({gen_event_EXIT, Module, {'EXIT', {kill_me, [_KillerHWM, KillerReins
     {message_queue_len, Len} = process_info(SinkPid, message_queue_len),
     error_logger:error_msg("Killing sink ~p, current message_queue_len:~p~n", [Sink, Len]),
     exit(SinkPid, kill),
-    timer:apply_after(KillerReinstallAfter, lager_app, start_handler, [Sink, Module, Config]),
+    _ = timer:apply_after(KillerReinstallAfter, lager_app, start_handler, [Sink, Module, Config]),
     {stop, normal, State};
 handle_info({gen_event_EXIT, Module, Reason}, #state{module=Module,
         config=Config, sink=Sink} = State) ->
@@ -98,7 +98,7 @@ handle_info(stop, State) ->
     {stop, normal, State};
 handle_info({'EXIT', _Pid, killed}, #state{module=Module, config=Config, sink=Sink} = State) ->
     Tmr = application:get_env(lager, killer_reinstall_after, 5000),
-    timer:apply_after(Tmr, lager_app, start_handler, [Sink, Module, Config]),
+    _ = timer:apply_after(Tmr, lager_app, start_handler, [Sink, Module, Config]),
     {stop, normal, State};
 handle_info(_Info, State) ->
     {noreply, State}.

src/lager_rotator_default.erl

@@ -77,7 +77,7 @@ rotate_logfile(File, 0) ->
     %% open the file in write-only mode to truncate/create it
     case file:open(File, [write]) of
         {ok, FD} ->
-            file:close(FD),
+            _ = file:close(FD),
             ok;
         Error ->
             Error

src/lager_util.erl

@@ -530,7 +530,7 @@ check_hwm(Shaper = #lager_shaper{lasttime = Last, dropped = Drop}) ->
                     end,
             {false, 0, Shaper#lager_shaper{dropped=Drop+NewDrops, timer=Timer}};
         _ ->
-            erlang:cancel_timer(Shaper#lager_shaper.timer),
+            _ = erlang:cancel_timer(Shaper#lager_shaper.timer),
             %% different second, reset all counters and allow it
             {true, Drop, Shaper#lager_shaper{dropped = 0, mps=0, lasttime = Now}}
     end.