Browse Source

Get loglevel of sink not default in transform

Previously, code would only look up the default sink's
loglevel, not the referenced sink name's loglevel.

In other words, if lager_event's loglevel was set to NONE,
it squelch all events from all sinks, and conversely if
a sink's loglevel was set to NONE, it would be silently
ignored.
pull/264/head
Mark Allen 10 years ago
parent
commit
aa195121e7
1 changed files with 3 additions and 3 deletions
  1. +3
    -3
      src/lager_transform.erl

+ 3
- 3
src/lager_transform.erl View File

@ -169,11 +169,11 @@ do_transform(Line, SinkName, Severity, Arguments0) ->
TracesVar = make_varname("__Traces", Line),
PidVar = make_varname("__Pid", Line),
%% Wrap the call to lager_dispatch log in a case that will avoid doing any work if this message is not elegible for logging
%% case {whereis(lager_event(lager_event), lager_config:get(loglevel, {?LOG_NONE, []})} of
%% case {whereis(Sink), lager_config:get(Sink, loglevel, {?LOG_NONE, []})} of
{'case', Line,
{tuple, Line,
[{call, Line, {atom, Line, whereis}, [{atom, Line, SinkName}]},
{call, Line, {remote, Line, {atom, Line, lager_config}, {atom, Line, get}}, [{atom, Line, loglevel}, {tuple, Line, [{integer, Line, 0},{nil, Line}]}]}]},
{call, Line, {remote, Line, {atom, Line, lager_config}, {atom, Line, get}}, [{atom, Line, SinkName}, {atom, Line, loglevel}, {tuple, Line, [{integer, Line, 0},{nil, Line}]}]}]},
[
%% {undefined, _} -> {error, lager_not_running}
{clause, Line,
@ -190,7 +190,7 @@ do_transform(Line, SinkName, Severity, Arguments0) ->
{op, Line, '/=', {op, Line, 'band', {var, Line, LevelVar}, {integer, Line, SeverityAsInt}}, {integer, Line, 0}},
{op, Line, '/=', {var, Line, TracesVar}, {nil, Line}}}]],
[
%% do the call to lager:dispatch_log
%% do the call to lager:dispatch_log/9
{call, Line, {remote, Line, {atom, Line, lager}, {atom, Line, do_log}},
[
{atom,Line,Severity},

Loading…
Cancel
Save