From d05139611268d8f3f1832f7f648ed7c11d93fd6b Mon Sep 17 00:00:00 2001 From: James Fish Date: Sat, 25 Oct 2014 09:40:02 +0100 Subject: [PATCH] Fix ct backend dialyzer warnings * Fix unmatched return * Fix set_loglevel call to store mask in state * Add common_test to plt for ct:pal spec --- Makefile | 3 ++- src/lager_common_test_backend.erl | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 4c61dd6..a864971 100644 --- a/Makefile +++ b/Makefile @@ -15,6 +15,7 @@ clean: distclean: clean ./rebar delete-deps -DIALYZER_APPS = kernel stdlib erts sasl eunit syntax_tools compiler crypto +DIALYZER_APPS = kernel stdlib erts sasl eunit syntax_tools compiler crypto \ + common_test include tools.mk diff --git a/src/lager_common_test_backend.erl b/src/lager_common_test_backend.erl index 9ed0dfc..2d5c426 100644 --- a/src/lager_common_test_backend.erl +++ b/src/lager_common_test_backend.erl @@ -39,7 +39,7 @@ bounce() -> bounce(error). bounce(Level) -> - application:stop(lager), + _ = application:stop(lager), lager:start(), gen_event:add_handler(lager_event, lager_common_test_backend, [Level, false]), %lager:set_loglevel(lager_common_test_backend, Level), @@ -88,7 +88,7 @@ handle_call(get_loglevel, #state{level=Level} = State) -> handle_call({set_loglevel, Level}, State) -> case lists:member(Level, ?LEVELS) of true -> - {ok, ok, State#state{level=lager_util:level_to_num(Level)}}; + {ok, ok, State#state{level=lager_util:config_to_mask(Level)}}; _ -> {ok, {error, bad_log_level}, State} end;