You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

187 line
8.3 KiB

  1. %% -*- erlang-indent-level: 4;indent-tabs-mode: nil -*-
  2. %% ex: ts=4 sw=4 et
  3. -module(rebar_xref_SUITE).
  4. -export([suite/0,
  5. init_per_suite/1,
  6. end_per_suite/1,
  7. init_per_testcase/2,
  8. end_per_testcase/2,
  9. all/0,
  10. xref_test/1,
  11. xref_ignore_test/1,
  12. xref_dep_hook/1]).
  13. -include_lib("common_test/include/ct.hrl").
  14. -include_lib("eunit/include/eunit.hrl").
  15. -include_lib("kernel/include/file.hrl").
  16. %% ===================================================================
  17. %% common_test callbacks
  18. %% ===================================================================
  19. suite() ->
  20. [].
  21. init_per_suite(Config) ->
  22. Config.
  23. end_per_suite(_Config) ->
  24. ok.
  25. init_per_testcase(xref_dep_hook, Config) ->
  26. Src = filename:join([?config(data_dir, Config), "recursive"]),
  27. Dst = filename:join([?config(priv_dir, Config), "recursive"]),
  28. ok = rebar_file_utils:cp_r([Src], Dst),
  29. GlobalDir = filename:join([?config(priv_dir, Config), "cache"]),
  30. State = rebar_state:new([{base_dir, filename:join([Dst, "_build"])}
  31. ,{global_rebar_dir, GlobalDir}
  32. ,{root_dir, Dst}]),
  33. [{apps, Dst}, {state, State} | Config];
  34. init_per_testcase(Case, Config) ->
  35. UpdConfig = rebar_test_utils:init_rebar_state(Config),
  36. AppDir = ?config(apps, UpdConfig),
  37. file:set_cwd(AppDir),
  38. Name = rebar_test_utils:create_random_name("xrefapp_"),
  39. Vsn = rebar_test_utils:create_random_vsn(),
  40. rebar_test_utils:create_empty_app(AppDir, Name, Vsn, [kernel, stdlib]),
  41. AppModules = [behaviour1, behaviour2, mymod, othermod],
  42. [write_src_file(AppDir, Name, Module, ignore_xref(Case)) || Module <- AppModules],
  43. RebarConfig = [{erl_opts, [debug_info]},
  44. {xref_checks, [deprecated_function_calls,deprecated_functions,
  45. undefined_function_calls,undefined_functions,
  46. exports_not_used,locals_not_used]}],
  47. [{app_name, Name},
  48. {rebar_config, RebarConfig} | UpdConfig].
  49. end_per_testcase(_, _Config) ->
  50. ok.
  51. all() ->
  52. [xref_test, xref_ignore_test, xref_dep_hook].
  53. %% ===================================================================
  54. %% Test cases
  55. %% ===================================================================
  56. xref_test(Config) ->
  57. AppDir = ?config(apps, Config),
  58. State = ?config(state, Config),
  59. Name = ?config(app_name, Config),
  60. RebarConfig = ?config(rebar_config, Config),
  61. Result = rebar3:run(rebar_state:new(State, RebarConfig, AppDir), ["xref"]),
  62. verify_results(xref_test, Name, Result).
  63. xref_ignore_test(Config) ->
  64. AppDir = ?config(apps, Config),
  65. State = ?config(state, Config),
  66. Name = ?config(app_name, Config),
  67. RebarConfig = ?config(rebar_config, Config),
  68. Result = rebar3:run(rebar_state:new(State, RebarConfig, AppDir), ["xref"]),
  69. verify_results(xref_ignore_test, Name, Result).
  70. xref_dep_hook(Config) ->
  71. rebar_test_utils:run_and_check(Config, [], ["compile"], {ok, []}).
  72. %% ===================================================================
  73. %% Helper functions
  74. %% ===================================================================
  75. ignore_xref(xref_ignore_test) ->
  76. true;
  77. ignore_xref(_) ->
  78. false.
  79. verify_results(TestCase, AppName, Results) ->
  80. {error, {rebar_prv_xref,
  81. {xref_issues, XrefResults, QueryResults}}} = Results,
  82. verify_test_results(TestCase, AppName, XrefResults, QueryResults).
  83. verify_test_results(xref_test, AppName, XrefResults, _QueryResults) ->
  84. AppModules = ["behaviour1", "behaviour2", "mymod", "othermod", "somemod"],
  85. [Behaviour1Mod, Behaviour2Mod, MyMod, OtherMod, SomeMod] =
  86. [list_to_atom(AppName ++ "_" ++ Mod) || Mod <- AppModules],
  87. UndefFuns = proplists:get_value(undefined_functions, XrefResults),
  88. UndefFunCalls = proplists:get_value(undefined_function_calls, XrefResults),
  89. LocalsNotUsed = proplists:get_value(locals_not_used, XrefResults),
  90. ExportsNotUsed = proplists:get_value(exports_not_used, XrefResults),
  91. DeprecatedFuns = proplists:get_value(deprecated_functions, XrefResults),
  92. DeprecatedFunCalls = proplists:get_value(deprecated_function_calls, XrefResults),
  93. ?assert(lists:member({SomeMod, notavailable, 1}, UndefFuns)),
  94. ?assert(lists:member({{OtherMod, somefunc, 0}, {SomeMod, notavailable, 1}},
  95. UndefFunCalls)),
  96. ?assert(lists:member({MyMod, fdeprecated, 0}, DeprecatedFuns)),
  97. ?assert(lists:member({{OtherMod, somefunc, 0}, {MyMod, fdeprecated, 0}},
  98. DeprecatedFunCalls)),
  99. ?assert(lists:member({MyMod, localfunc2, 0}, LocalsNotUsed)),
  100. ?assert(lists:member({Behaviour1Mod, behaviour_info, 1}, ExportsNotUsed)),
  101. ?assert(lists:member({Behaviour2Mod, behaviour_info, 1}, ExportsNotUsed)),
  102. ?assert(lists:member({MyMod, other2, 1}, ExportsNotUsed)),
  103. ?assert(lists:member({OtherMod, somefunc, 0}, ExportsNotUsed)),
  104. ?assertNot(lists:member({MyMod, bh1_a, 1}, ExportsNotUsed)),
  105. ?assertNot(lists:member({MyMod, bh1_b, 1}, ExportsNotUsed)),
  106. ?assertNot(lists:member({MyMod, bh2_a, 1}, ExportsNotUsed)),
  107. ?assertNot(lists:member({MyMod, bh2_b, 1}, ExportsNotUsed)),
  108. ok;
  109. verify_test_results(xref_ignore_test, AppName, XrefResults, _QueryResults) ->
  110. AppModules = ["behaviour1", "behaviour2", "mymod", "othermod", "somemod"],
  111. [_Behaviour1Mod, _Behaviour2Mod, _MyMod, _OtherMod, SomeMod] =
  112. [list_to_atom(AppName ++ "_" ++ Mod) || Mod <- AppModules],
  113. UndefFuns = proplists:get_value(undefined_functions, XrefResults),
  114. ?assertNot(lists:keymember(undefined_function_calls, 1, XrefResults)),
  115. ?assertNot(lists:keymember(locals_not_used, 1, XrefResults)),
  116. ?assertNot(lists:keymember(exports_not_used, 1, XrefResults)),
  117. ?assertNot(lists:keymember(deprecated_functions, 1, XrefResults)),
  118. ?assertNot(lists:keymember(deprecated_function_calls, 1, XrefResults)),
  119. ?assert(lists:member({SomeMod, notavailable, 1}, UndefFuns)),
  120. ok.
  121. write_src_file(Dir, AppName, Module, IgnoreXref) ->
  122. Erl = filename:join([Dir, "src", module_name(AppName, Module)]),
  123. ok = filelib:ensure_dir(Erl),
  124. ok = ec_file:write(Erl, get_module_body(Module, AppName, IgnoreXref)).
  125. module_name(AppName, Module) ->
  126. lists:flatten([AppName, "_", atom_to_list(Module), ".erl"]).
  127. get_module_body(behaviour1, AppName, IgnoreXref) ->
  128. ["-module(", AppName, "_behaviour1).\n",
  129. "-export([behaviour_info/1]).\n",
  130. ["-ignore_xref({behaviour_info,1}).\n" || X <- [IgnoreXref], X =:= true],
  131. "behaviour_info(callbacks) -> [{bh1_a,1},{bh1_b,1}];\n",
  132. "behaviour_info(_Other) -> undefined.\n"];
  133. get_module_body(behaviour2, AppName, IgnoreXref) ->
  134. ["-module(", AppName, "_behaviour2).\n",
  135. "-export([behaviour_info/1]).\n",
  136. ["-ignore_xref({behaviour_info,1}).\n" || X <- [IgnoreXref], X =:= true],
  137. "behaviour_info(callbacks) -> [{bh2_a,1},{bh2_b,1}];\n",
  138. "behaviour_info(_Other) -> undefined.\n"];
  139. get_module_body(mymod, AppName, IgnoreXref) ->
  140. ["-module(", AppName, "_mymod).\n",
  141. "-export([bh1_a/1,bh1_b/1,bh2_a/1,bh2_b/1,"
  142. "other1/1,other2/1,fdeprecated/0]).\n",
  143. ["-ignore_xref([{other2,1},{localfunc2,0},{fdeprecated,0}]).\n"
  144. || X <- [IgnoreXref], X =:= true],
  145. "-behaviour(", AppName, "_behaviour1).\n", % 2 behaviours
  146. "-behavior(", AppName, "_behaviour2).\n",
  147. "-deprecated({fdeprecated,0}).\n", % deprecated function
  148. "bh1_a(A) -> localfunc1(bh1_a, A).\n", % behaviour functions
  149. "bh1_b(A) -> localfunc1(bh1_b, A).\n",
  150. "bh2_a(A) -> localfunc1(bh2_a, A).\n",
  151. "bh2_b(A) -> localfunc1(bh2_b, A).\n",
  152. "other1(A) -> localfunc1(other1, A).\n", % regular exported functions
  153. "other2(A) -> localfunc1(other2, A).\n",
  154. "localfunc1(A, B) -> {A, B}.\n", % used local
  155. "localfunc2() -> ok.\n", % unused local
  156. "fdeprecated() -> ok.\n" % deprecated function
  157. ];
  158. get_module_body(othermod, AppName, IgnoreXref) ->
  159. ["-module(", AppName, "_othermod).\n",
  160. "-export([somefunc/0]).\n",
  161. [["-ignore_xref([{", AppName, "_somemod,notavailable,1},{somefunc,0}]).\n",
  162. "-ignore_xref({", AppName, "_mymod,fdeprecated,0}).\n"]
  163. || X <- [IgnoreXref], X =:= true],
  164. "somefunc() ->\n",
  165. " ", AppName, "_mymod:other1(arg),\n",
  166. " ", AppName, "_somemod:notavailable(arg),\n",
  167. " ", AppName, "_mymod:fdeprecated().\n"].