Merge pull request #2240 from tsloughter/force-tls1.2

force use of tls1.2 for http fetching to work on OTP-23-rc1

bootstrap

@@ -108,7 +108,7 @@ extract(Binary) ->
     {ok, Contents}.
 
 request(Url) ->
-    HttpOptions = [{relaxed, true} | get_proxy_auth()],
+    HttpOptions = [{ssl, [{versions, ['tlsv1.2']}]}, {relaxed, true} | get_proxy_auth()],
 
     case httpc:request(get, {Url, []},
                        HttpOptions,

src/r3_hex_http_httpc.erl

@@ -13,10 +13,13 @@
 request(Method, URI, ReqHeaders, Body, AdapterConfig) ->
     Profile = maps:get(profile, AdapterConfig, default),
     Request = build_request(URI, ReqHeaders, Body),
-    {ok, {{_, StatusCode, _}, RespHeaders, RespBody}} =
-        httpc:request(Method, Request, [], [{body_format, binary}], Profile),
-    RespHeaders2 = load_headers(RespHeaders),
-    {ok, {StatusCode, RespHeaders2, RespBody}}.
+    case httpc:request(Method, Request, [{ssl, rebar_utils:ssl_opts(URI)}],
+                       [{body_format, binary}], Profile) of
+        {ok, {{_, StatusCode, _}, RespHeaders, RespBody}} ->
+            RespHeaders2 = load_headers(RespHeaders),
+            {ok, {StatusCode, RespHeaders2, RespBody}};
+        {error, Reason} -> {error, Reason}
+    end.
 
 %%====================================================================
 %% Internal functions

src/rebar_utils.erl

@@ -1010,9 +1010,9 @@ is_list_of_strings(List) when is_list(List) ->
 ssl_opts(Url) ->
     case get_ssl_config() of
         ssl_verify_enabled ->
-            ssl_opts(ssl_verify_enabled, Url);
+            [{versions, ['tlsv1.2']} | ssl_opts(ssl_verify_enabled, Url)];
         ssl_verify_disabled ->
-            [{verify, verify_none}]
+            [{versions, ['tlsv1.2']}, {verify, verify_none}]
     end.
 
 %%------------------------------------------------------------------------------