Merge branch 'kellymclaughlin-dev-mode-release-tests' into fancy-profile-merge-fun

test/rebar_release_SUITE.erl

@@ -3,7 +3,10 @@
 -include_lib("common_test/include/ct.hrl").
 -include_lib("eunit/include/eunit.hrl").
 
-all() -> [release, tar].
+all() -> [release,
+          dev_mode_release,
+          profile_dev_mode_override_release,
+          tar].
 
 init_per_testcase(Case, Config0) ->
     Config = rebar_test_utils:init_rebar_state(Config0),
@@ -33,9 +36,46 @@ release(Config) ->
     rebar_test_utils:run_and_check(
       Config, RebarConfig,
       ["release"],
-      {ok, [{release, list_to_atom(Name), Vsn}]}
+      {ok, [{release, list_to_atom(Name), Vsn, false}]}
      ).
 
+dev_mode_release(Config) ->
+    AppDir = ?config(apps, Config),
+    Name = ?config(name, Config),
+    Vsn = "1.0.0",
+    {ok, RebarConfig} =
+        file:consult(rebar_test_utils:create_config(AppDir,
+                                                    [{relx, [{release, {list_to_atom(Name), Vsn},
+                                                              [list_to_atom(Name)]},
+                                                             {lib_dirs, [AppDir]},
+                                                             {dev_mode, true}]}])),
+    rebar_test_utils:run_and_check(
+      Config, RebarConfig,
+      ["release"],
+      {ok, [{release, list_to_atom(Name), Vsn, true}]}
+     ).
+
+
+profile_dev_mode_override_release(Config) ->
+    AppDir = ?config(apps, Config),
+    Name = ?config(name, Config),
+    Vsn = "1.0.0",
+    {ok, RebarConfig} =
+        file:consult(rebar_test_utils:create_config(AppDir,
+                                                    [{relx, [{release, {list_to_atom(Name), Vsn},
+                                                              [list_to_atom(Name)]},
+                                                             {lib_dirs, [AppDir]},
+                                                             {dev_mode, true}]},
+                                                     {profiles,
+                                                      [{ct,
+                                                        [{relx, [{dev_mode, false}]}]}]}])),
+    rebar_test_utils:run_and_check(
+      Config, RebarConfig,
+      ["as", "ct", "release"],
+      {ok, [{release, list_to_atom(Name), Vsn, false}]}
+     ).
+
+
 tar(Config) ->
     AppDir = ?config(apps, Config),
     Name = ?config(name, Config),
@@ -48,5 +88,5 @@ tar(Config) ->
     rebar_test_utils:run_and_check(
       Config, RebarConfig,
       ["tar"],
-      {ok, [{release, list_to_atom(Name), Vsn}, {tar, Name, Vsn}]}
+      {ok, [{release, list_to_atom(Name), Vsn, false}, {tar, Name, Vsn}]}
      ).

test/rebar_test_utils.erl

@@ -217,7 +217,7 @@ check_results(AppDir, Expected) ->
                         ?assertEqual(iolist_to_binary(Vsn),
                                      iolist_to_binary(LockVsn))
                 end
-        ;  ({release, Name, Vsn}) ->
+        ;  ({release, Name, Vsn, ExpectedDevMode}) ->
                 ct:pal("Release: ~p-~s", [Name, Vsn]),
                 {ok, Cwd} = file:get_cwd(),
                 try
@@ -228,6 +228,15 @@ check_results(AppDir, Expected) ->
                     {ok, RelxState2} = rlx_prv_app_discover:do(RelxState1),
                     {ok, RelxState3} = rlx_prv_rel_discover:do(RelxState2),
 
+                    LibDir = filename:join([ReleaseDir, Name, "lib"]),
+                    {ok, RelLibs} = file:list_dir(LibDir),
+                    IsSymLinkFun =
+                        fun(X) ->
+                                ec_file:is_symlink(filename:join(LibDir, X))
+                        end,
+                    DevMode = lists:all(IsSymLinkFun, RelLibs),
+                    ?assertEqual(ExpectedDevMode, DevMode),
+
                     %% throws not_found if it doesn't exist
                     rlx_state:get_realized_release(RelxState3, Name, Vsn)
                 catch