ソースを参照

change cover html generation to produce valid html

- added missing doctype
- added encoding statement
- removed invalid additional opening <body> tag
pull/3/head
Philip Mueller 12年前
コミット
4ae4a80219
1個のファイルの変更4行の追加2行の削除
  1. +4
    -2
      src/rebar_eunit.erl

+ 4
- 2
src/rebar_eunit.erl ファイルの表示

@ -524,7 +524,9 @@ align_notcovered_count(Module, Covered, NotCovered, true) ->
cover_write_index(Coverage, SrcModules) -> cover_write_index(Coverage, SrcModules) ->
{ok, F} = file:open(filename:join([?EUNIT_DIR, "index.html"]), [write]), {ok, F} = file:open(filename:join([?EUNIT_DIR, "index.html"]), [write]),
ok = file:write(F, "<html><head><title>Coverage Summary</title></head>\n"),
ok = file:write(F, "<!DOCTYPE HTML><html>\n" ++
"<head><meta charset=\"utf-8\"><title>Coverage Summary</title></head>\n" ++
"<body>\n"),
IsSrcCoverage = fun({Mod,_C,_N}) -> lists:member(Mod, SrcModules) end, IsSrcCoverage = fun({Mod,_C,_N}) -> lists:member(Mod, SrcModules) end,
{SrcCoverage, TestCoverage} = lists:partition(IsSrcCoverage, Coverage), {SrcCoverage, TestCoverage} = lists:partition(IsSrcCoverage, Coverage),
cover_write_index_section(F, "Source", SrcCoverage), cover_write_index_section(F, "Source", SrcCoverage),
@ -542,7 +544,7 @@ cover_write_index_section(F, SectionName, Coverage) ->
TotalCoverage = percentage(Covered, NotCovered), TotalCoverage = percentage(Covered, NotCovered),
%% Write the report %% Write the report
ok = file:write(F, ?FMT("<body><h1>~s Summary</h1>\n", [SectionName])),
ok = file:write(F, ?FMT("<h1>~s Summary</h1>\n", [SectionName])),
ok = file:write(F, ?FMT("<h3>Total: ~s</h3>\n", [TotalCoverage])), ok = file:write(F, ?FMT("<h3>Total: ~s</h3>\n", [TotalCoverage])),
ok = file:write(F, "<table><tr><th>Module</th><th>Coverage %</th></tr>\n"), ok = file:write(F, "<table><tr><th>Module</th><th>Coverage %</th></tr>\n"),

読み込み中…
キャンセル
保存