From e903bb9acd2d60c6d27cfa042091935f2652fc08 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Wed, 26 Aug 2020 16:11:55 -0600 Subject: [PATCH] add TODO notes about improving checkouts related errors --- src/rebar_prv_lock.erl | 2 ++ src/rebar_prv_upgrade.erl | 1 + 2 files changed, 3 insertions(+) diff --git a/src/rebar_prv_lock.erl b/src/rebar_prv_lock.erl index 03cf36ca..a3e4a999 100644 --- a/src/rebar_prv_lock.erl +++ b/src/rebar_prv_lock.erl @@ -40,6 +40,8 @@ do(State) -> OldLockNames = [element(1,L) || L <- OldLocks], NewLockNames = [element(1,L) || L <- Locks], + + %% TODO: don't output this message if the dep is now a checkout rebar_utils:info_useless(OldLockNames, NewLockNames), {ok, State1}; diff --git a/src/rebar_prv_upgrade.erl b/src/rebar_prv_upgrade.erl index 565f342c..e827f735 100644 --- a/src/rebar_prv_upgrade.erl +++ b/src/rebar_prv_upgrade.erl @@ -217,6 +217,7 @@ prepare_locks([Name|Names], Deps, Locks, Unlocks, Dict, AltDeps) -> false -> case rebar_utils:tup_find(AtomName, AltDeps) of false -> + %% TODO: output a different error if the app is a checkout ?PRV_ERROR({unknown_dependency, Name}); _ -> % non-default profile dependency found, pass through prepare_locks(Names, Deps, Locks, Unlocks, Dict, AltDeps)